Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make linters happy #1051

Closed
yarikoptic opened this issue Jul 8, 2022 · 3 comments · Fixed by #1052
Closed

make linters happy #1051

yarikoptic opened this issue Jul 8, 2022 · 3 comments · Fixed by #1052
Assignees
Labels

Comments

@yarikoptic
Copy link
Member

keep getting emails

   3     Jul 08 Yaroslav Halche *-7.0* ( 31K/0) [dandi/dandi-cli] Run failed: Linters - master (26f6cf2)                                                                                                             
2680     Jul 01 Yaroslav Halche *-7.9* ( 31K/0) [dandi/dandi-cli] Run failed: Linters - master (ed46af3)                                                                                                             
10233     Jun 02 Yaroslav Halche *-7.2* ( 31K/0) [dandi/dandi-cli] Run failed: Linters - master (493b15f)                                                                                                            
19843     Apr 25 Yaroslav Halche *-7.2* ( 31K/0) [dandi/dandi-cli] Run failed: Linters - master (185bbfc)         `

so something might be broken/needs fixing?

@jwodder
Copy link
Member

jwodder commented Jul 8, 2022

@yarikoptic Here are all of the "Lint" failures on master. It looks like they're all due to git checkout failing with "reference is not a tree", almost always on a merge, almost always right after another (successfully-linted) merge. I suspect this is some sort of GitHub problem triggered by two consecutive merges.

@yarikoptic
Copy link
Member Author

ah, cool... makes sense -- probably due to shallow clone. Let's disable shallow cloning of dandi-cli in our actions . Or make it like 100 commits deep or so. repo is not that big anyways.

yarikoptic added a commit that referenced this issue Jul 8, 2022
Clone entire repo in "Lint" action
@github-actions
Copy link

🚀 Issue was released in 0.45.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants