Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include leading text of response bodies in HTTP error messages #1023

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented May 31, 2022

Closes #996.

@jwodder jwodder added the patch Increment the patch version when merged label May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (791ac12) to head (bf7cbba).
Report is 1105 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   87.60%   87.67%   +0.06%     
==========================================
  Files          65       65              
  Lines        8247     8249       +2     
==========================================
+ Hits         7225     7232       +7     
+ Misses       1022     1017       -5     
Flag Coverage Δ
unittests 87.67% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

what has stopped you from making it out of draft mode @jwodder ?

@jwodder
Copy link
Member Author

jwodder commented Jun 30, 2022

@yarikoptic I don't remember. I think this issue may have been created around the time that the "Create PR" button kept randomly switching to "Create Draft PR".

@jwodder jwodder marked this pull request as ready for review June 30, 2022 14:44
@yarikoptic
Copy link
Member

coolio, let's then see what it would bring us. Thanks @jwodder !

@yarikoptic yarikoptic merged commit f7bb0a9 into master Jun 30, 2022
@yarikoptic yarikoptic deleted the gh-996 branch June 30, 2022 15:46
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

🚀 PR was released in 0.42.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upload: Channel back error message from server
2 participants