Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test_move_command_too_few_paths support DANDI_DEVEL=1 #1040

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Make test_move_command_too_few_paths support DANDI_DEVEL=1 #1040

merged 1 commit into from
Jul 1, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 1, 2022

Fixes #1039.

@jwodder jwodder added the tests Add or improve existing tests label Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (f7bb0a9) to head (4a50d69).
Report is 1078 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1040   +/-   ##
=======================================
  Coverage   88.36%   88.36%           
=======================================
  Files          69       69           
  Lines        9066     9066           
=======================================
  Hits         8011     8011           
  Misses       1055     1055
Flag Coverage Δ
unittests 88.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

Thank you!

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Jul 1, 2022
@yarikoptic
Copy link
Member

marked for release so any downstream testing against released dandi-cli also gets fixed

@yarikoptic yarikoptic merged commit ed46af3 into master Jul 1, 2022
@yarikoptic yarikoptic deleted the gh-1039 branch July 1, 2022 18:35
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

🚀 PR was released in 0.42.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release Create a release when this pr is merged released tests Add or improve existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_move_command_too_few_paths FAILs in downstream testing of dandischema
2 participants
@jwodder @yarikoptic