Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dandi move: Include all mismatches in error messages #1064

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 15, 2022

Closes #1060.

@jwodder jwodder added patch Increment the patch version when merged cmd-move labels Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.42%. Comparing base (e4dc875) to head (d61605e).
Report is 1020 commits behind head on master.

Files Patch % Lines
dandi/move.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
+ Coverage   88.35%   88.42%   +0.06%     
==========================================
  Files          72       72              
  Lines        9250     9253       +3     
==========================================
+ Hits         8173     8182       +9     
+ Misses       1077     1071       -6     
Flag Coverage Δ
unittests 88.42% <92.30%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

oh well, it wouldn't be very easy to copy / paste all those paths to be fed into dandi upload (which was the original motivation) but at least possible to dump into a file and post-process if so really desired, so let's proceed with this for now. Thank you @jwodder

@yarikoptic yarikoptic merged commit dddc98a into master Jul 15, 2022
@yarikoptic yarikoptic deleted the gh-1060 branch July 15, 2022 20:36
@github-actions
Copy link

🚀 PR was released in 0.45.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd-move patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move: report all problematic paths at once (not just error out on the first)
2 participants