Don't try to cancel failed Zarr uploads twice #1139
Conversation
Codecov ReportBase: 87.88% // Head: 87.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
+ Coverage 87.88% 87.93% +0.04%
==========================================
Files 73 73
Lines 8584 8585 +1
==========================================
+ Hits 7544 7549 +5
+ Misses 1040 1036 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -450,6 +450,7 @@ def mkzarr() -> str: | |||
| f.cancel() | |||
| executor.shutdown() | |||
| client.delete(f"/zarr/{zarr_id}/upload/") | |||
| ZARR_UPLOADS_IN_PROGRESS.discard(upload_data) | |||
There was a problem hiding this comment.
uff, took me awhile to locate this ZARR_UPLOADS_IN_PROGRESS which is apparently not a local to the function, but bound at module level below at some line 576, uff . With that it is a global structure, it makes sense.
|
Thank you! looks good! |
|
🚀 PR was released in |
Fixed a bug seen in #1028 (comment).