Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklisting the most recent hdmf version 3.5.0 forbidding its use and breaking CI/testing. #1190

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

TheChymera
Copy link
Contributor

No description provided.

@TheChymera
Copy link
Contributor Author

@yarikoptic

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 88.83% // Head: 89.08% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (6d065ec) compared to base (5389d21).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
+ Coverage   88.83%   89.08%   +0.25%     
==========================================
  Files          76       76              
  Lines        9288     9448     +160     
==========================================
+ Hits         8251     8417     +166     
+ Misses       1037     1031       -6     
Flag Coverage Δ
unittests 89.08% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/support/threaded_walk.py 93.10% <0.00%> (-1.73%) ⬇️
dandi/cli/cmd_digest.py 100.00% <0.00%> (ø)
dandi/validate_types.py 100.00% <0.00%> (ø)
dandi/support/digests.py 100.00% <0.00%> (ø)
dandi/cli/cmd_instances.py 100.00% <0.00%> (ø)
dandi/cli/tests/test_move.py 100.00% <0.00%> (ø)
dandi/tests/test_metadata.py 100.00% <0.00%> (ø)
dandi/tests/test_validate.py 100.00% <0.00%> (ø)
dandi/cli/tests/test_cmd_ls.py 100.00% <0.00%> (ø)
dandi/cli/tests/test_digest.py 100.00% <0.00%> (ø)
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic marked this pull request as ready for review January 20, 2023 20:48
@yarikoptic
Copy link
Member

Thanks! It makes CI green, took it out of Draft, merging after adjusting title to become more specific/worthy the changelog entry.

@yarikoptic yarikoptic changed the title Blacklisting hdmf version with issues Blacklisting the most recent hdmf version 3.5.0 forbidding its use and breaking CI/testing. Jan 20, 2023
@yarikoptic yarikoptic merged commit d958555 into master Jan 20, 2023
@yarikoptic yarikoptic deleted the hdmf branch January 20, 2023 20:49
@jwodder jwodder added the dependencies Update one or more dependencies version label Feb 10, 2023
@github-actions
Copy link

🚀 PR was released in 0.49.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants