Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass $USER to tox envs #1201

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Pass $USER to tox envs #1201

merged 1 commit into from
Feb 3, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 3, 2023

Recent versions of Docker and/or Docker Compose require the $USER envvar to be set, yet tox unsets this envvar by default. This PR fixes that.

@jwodder jwodder added the internal Changes only affect the internal API label Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 89.16% // Head: 89.16% // No change to project coverage 👍

Coverage data is based on head (5ec6cf8) compared to base (e81be32).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1201   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files          76       76           
  Lines        9471     9471           
=======================================
  Hits         8445     8445           
  Misses       1026     1026           
Flag Coverage Δ
unittests 89.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jwodder
Copy link
Member Author

jwodder commented Feb 3, 2023

The tests are failing because of a cert error with ontobee.org.

@yarikoptic
Copy link
Member

eh - tests fail avalanche due to expired certificates of ontobee.org
2023-02-03T15:12:47.1234955Z /opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/urllib3/util/retry.py:592: in increment
2023-02-03T15:12:47.1235497Z     raise MaxRetryError(_pool, url, error or ResponseError(cause))
2023-02-03T15:12:47.1236757Z E   urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='ontobee.org', port=443): Max retries exceeded with url: /browser/rdf.php?o=NCBITaxon&iri=http://purl.obolibrary.org/obo/NCBITaxon_1234175 (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1129)')))
2023-02-03T15:12:47.1237493Z 
❯ wget -S -O- http://purl.obolibrary.org/obo/NCBITaxon_28584
--2023-02-03 11:03:23--  http://purl.obolibrary.org/obo/NCBITaxon_28584
Resolving purl.obolibrary.org (purl.obolibrary.org)... 3.223.180.112
Connecting to purl.obolibrary.org (purl.obolibrary.org)|3.223.180.112|:80... connected.
HTTP request sent, awaiting response... 
  HTTP/1.1 303 See Other
  Date: Fri, 03 Feb 2023 16:03:23 GMT
  Server: Apache/2.4.41 (Ubuntu)
  Location: http://www.ontobee.org/browser/rdf.php?o=NCBITaxon&iri=http://purl.obolibrary.org/obo/NCBITaxon_28584
  Content-Length: 397
  Keep-Alive: timeout=5, max=100
  Connection: Keep-Alive
  Content-Type: text/html; charset=iso-8859-1
Location: http://www.ontobee.org/browser/rdf.php?o=NCBITaxon&iri=http://purl.obolibrary.org/obo/NCBITaxon_28584 [following]
--2023-02-03 11:03:23--  http://www.ontobee.org/browser/rdf.php?o=NCBITaxon&iri=http://purl.obolibrary.org/obo/NCBITaxon_28584
Resolving www.ontobee.org (www.ontobee.org)... 141.214.2.48
Connecting to www.ontobee.org (www.ontobee.org)|141.214.2.48|:80... connected.
HTTP request sent, awaiting response... 
  HTTP/1.1 301 Moved Permanently
  Date: Fri, 03 Feb 2023 16:03:23 GMT
  Server: Apache/2.4.6 (Red Hat Enterprise Linux) OpenSSL/1.0.2k-fips PHP/7.2.21 mod_wsgi/4.6.5 Python/3.5 mod_perl/2.0.11 Perl/v5.16.3
  Location: https://ontobee.org/browser/rdf.php?o=NCBITaxon&iri=http://purl.obolibrary.org/obo/NCBITaxon_28584
  Content-Length: 310
  Keep-Alive: timeout=5, max=100
  Connection: Keep-Alive
  Content-Type: text/html; charset=iso-8859-1
Location: https://ontobee.org/browser/rdf.php?o=NCBITaxon&iri=http://purl.obolibrary.org/obo/NCBITaxon_28584 [following]
--2023-02-03 11:03:23--  https://ontobee.org/browser/rdf.php?o=NCBITaxon&iri=http://purl.obolibrary.org/obo/NCBITaxon_28584
Resolving ontobee.org (ontobee.org)... 141.214.2.48
Connecting to ontobee.org (ontobee.org)|141.214.2.48|:443... connected.
ERROR: The certificate of ‘ontobee.org’ is not trusted.
ERROR: The certificate of ‘ontobee.org’ has expired.
The certificate has expired

submitted OntoZoo/ontobee#188 to inquire.

@yarikoptic
Copy link
Member

certificate issue was fixed, restarted failed jobs.

@yarikoptic
Copy link
Member

all green, let's proceed!

@yarikoptic yarikoptic merged commit 35fd2d5 into master Feb 3, 2023
@yarikoptic yarikoptic deleted the tox-user branch February 3, 2023 18:48
@github-actions
Copy link

🚀 PR was released in 0.49.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants