-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bidsschematools 0.7.0 API usage update #1243
Conversation
what's the plan for this PR @TheChymera ? |
@yarikoptic pending BST release. |
@yarikoptic @TheChymera bidsschematools 0.7.0 is now out, and dandi-cli's tests are failing due to the lack of this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1243 +/- ##
===========================================
- Coverage 88.44% 62.17% -26.28%
===========================================
Files 76 76
Lines 9952 10133 +181
===========================================
- Hits 8802 6300 -2502
- Misses 1150 3833 +2683
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're committing to dropping 3.7 support, I suppose you'll also want to get rid of this placeholder?
@yarikoptic Agreed. |
@jwodder yeah, didn't include the delete in this PR because I didn't want to make the BST fix hinge on that bit. |
62d3e8c
to
f76e557
Compare
🚀 PR was released in |
To be merged after the prospective
0.7.0
release of BST.