Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidsschematools 0.7.0 API usage update #1243

Merged
merged 5 commits into from
May 19, 2023
Merged

Bidsschematools 0.7.0 API usage update #1243

merged 5 commits into from
May 19, 2023

Conversation

TheChymera
Copy link
Contributor

To be merged after the prospective 0.7.0 release of BST.

@yarikoptic
Copy link
Member

what's the plan for this PR @TheChymera ?

@TheChymera
Copy link
Contributor Author

@yarikoptic pending BST release.

@jwodder
Copy link
Member

jwodder commented May 19, 2023

@yarikoptic @TheChymera bidsschematools 0.7.0 is now out, and dandi-cli's tests are failing due to the lack of this PR.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -26.28 ⚠️

Comparison is base (9b7ce30) 88.44% compared to head (62d3e8c) 62.17%.

❗ Current head 62d3e8c differs from pull request most recent head f76e557. Consider uploading reports for the commit f76e557 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1243       +/-   ##
===========================================
- Coverage   88.44%   62.17%   -26.28%     
===========================================
  Files          76       76               
  Lines        9952    10133      +181     
===========================================
- Hits         8802     6300     -2502     
- Misses       1150     3833     +2683     
Flag Coverage Δ
unittests 62.17% <25.00%> (-26.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/fixtures.py 77.32% <0.00%> (-20.01%) ⬇️
dandi/validate.py 95.65% <100.00%> (-2.18%) ⬇️

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jwodder jwodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're committing to dropping 3.7 support, I suppose you'll also want to get rid of this placeholder?

setup.cfg Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
@yarikoptic yarikoptic added the release Create a release when this pr is merged label May 19, 2023
@yarikoptic
Copy link
Member

I am marking this as a release. I think we then simply can skip merging #1293 . agree @jwodder ?

@jwodder
Copy link
Member

jwodder commented May 19, 2023

@yarikoptic Agreed.

@TheChymera
Copy link
Contributor Author

TheChymera commented May 19, 2023

@jwodder yeah, didn't include the delete in this PR because I didn't want to make the BST fix hinge on that bit.

@TheChymera TheChymera force-pushed the bst07 branch 2 times, most recently from 62d3e8c to f76e557 Compare May 19, 2023 19:32
@yarikoptic yarikoptic merged commit f695558 into master May 19, 2023
@yarikoptic yarikoptic deleted the bst07 branch May 19, 2023 21:33
@github-actions
Copy link

🚀 PR was released in 0.55.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants