Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for change in Zarr checksum format #933

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Update for change in Zarr checksum format #933

merged 2 commits into from
Mar 22, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 2, 2022

To accompany dandi/dandi-schema#120

Cannot be tested until after dandischema 0.6.0 is released (and then further edits will be needed to update some test cases that hardcode checksums).

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #933 (69f9326) into master (a941ab4) will decrease coverage by 0.05%.
The diff coverage is 90.32%.

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
- Coverage   87.40%   87.35%   -0.06%     
==========================================
  Files          62       62              
  Lines        7695     7688       -7     
==========================================
- Hits         6726     6716      -10     
- Misses        969      972       +3     
Flag Coverage Δ
unittests 87.35% <90.32%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/files.py 79.44% <0.00%> (ø)
dandi/cli/tests/test_digest.py 100.00% <100.00%> (ø)
dandi/support/digests.py 100.00% <100.00%> (ø)
dandi/support/tests/test_digests.py 100.00% <100.00%> (ø)
dandi/dandiarchive.py 83.68% <0.00%> (-1.68%) ⬇️
dandi/download.py 87.11% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a941ab4...69f9326. Read the comment docs.

@jwodder jwodder marked this pull request as ready for review March 17, 2022 13:41
@yarikoptic
Copy link
Member

0.6.0 was released, so time to "test"/merge/release asap @jwodder ?

@jwodder
Copy link
Member Author

jwodder commented Mar 21, 2022

@yarikoptic I already updated the tests. The release should include #938 as well.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Mar 22, 2022
@yarikoptic
Copy link
Member

#938 is already merged, so let's proceed with merge/release of this one

@yarikoptic yarikoptic merged commit c32e7f1 into master Mar 22, 2022
@yarikoptic yarikoptic deleted the schema-120 branch March 22, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged zarr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants