Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html to better handle mobile devices #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

antithalian
Copy link
Contributor

Adds the meta element for viewport, which, I think, should help with the size issues on mobile.

should fix size issues on mobile, I think
@danerwilliams
Copy link
Owner

Screen Shot 2020-12-24 at 11 40 29 AM
still looks fairly weird on mobile. maybe we could set like a maximum width of the file selection and text input elements so that on desktop it doesn't take up the full width of the screen, but if the width of the screen is small than the maximum width like on mobile then it takes up the full width?

@antithalian
Copy link
Contributor Author

Hmm. Is there any way we can gate the size on the size of the screen in play? Or can we set the width in rem to have it be based on screen size?

@danerwilliams
Copy link
Owner

You can do a percentage but then it would scale really large on a desktop display. I think there's a max width property along with flex box in css thats probably our best bet.

sets a min + max width for our input boxes
@antithalian
Copy link
Contributor Author

Most common mobile devices now look acceptable in Chrome's devtools viewer. There's probably a way to programmatically change the placeholder text size instead of just making the message a bit shorter, but my research/testing didn't turn anything up in a little while of Googling.

@danerwilliams
Copy link
Owner

image
it still looks off to me :/

@antithalian
Copy link
Contributor Author

That’s weird, it looked OK when I tried it. Although that’s a standard “but it works on my machine” response...

I’ll try running it on my network and see if it looks better on the actual phone hardware.

@antithalian
Copy link
Contributor Author

Here's screenshots from an iPhone 11 and a 5s. Looks ok, I think?

iPhone 11

iPhone 5s

@danerwilliams
Copy link
Owner

what's it look like in chrome dev tools as mobile device -> responsive for you (or a specific device)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants