misc cleanup: remove unused method/helper files + add missing generics #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, I'm wondering if we could cleanup a little bit the |
|
Thanks, I think all the important settings are now set via the builder so we can get rid of |
|
ok, this will allow to clean quite a lot of code :). I will provide a separate PR for the refactoring of the Configuration class. |
|
Looks good, merging. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr remove some unused helpers and a whole class (GenerateBigFile.java ).
Additionally, it finally add all the missing generic parameters + some misc. cleanups.