Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROJECT: Templates for openhtmltopdf. Initial commit. #544

Merged
merged 4 commits into from
Sep 6, 2020
Merged

PROJECT: Templates for openhtmltopdf. Initial commit. #544

merged 4 commits into from
Sep 6, 2020

Conversation

danfickle
Copy link
Owner

@danfickle danfickle commented Aug 31, 2020 •
edited
Loading

Scope

This sub-project will provide out-of-the-box templates for openhtmltopdf. The sub-module will generate a website with previews of these templates as well as the Thymeleaf template and raw HTML.

TODO:

  • Flesh out README.
  • Generate index.html for all templates.
  • Link to PDF preview from details page.
  • Automatic running and testing through Junit.
  • Github action to build website and publish to another repository.
  • Add test proofs.

@danfickle
PROJECT: Templates for openhtmltopdf. Initial commit.
98fbe13 
Mostly complete except for index page and testing.
@danfickle danfickle marked this pull request as draft August 31, 2020 08:07
@danfickle danfickle marked this pull request as ready for review September 6, 2020 04:41
@danfickle danfickle merged commit ab3946f into open-dev-v1 Sep 6, 2020
@danfickle danfickle deleted the templates_project branch September 6, 2020 04:44
@danfickle
Copy link
Owner Author

The website is at:
https://danfickle.github.io/pdf-templates/index.html

danfickle added a commit that referenced this pull request Sep 6, 2020
@danfickle
#544 Update README with link to templates site. [ci skip]
4a0612f
StephanSchrader pushed a commit to StephanSchrader/openhtmltopdf that referenced this pull request Oct 12, 2020
@danfickle
danfickle#544 Update README with link to templates site. [ci skip]
5470152
@danfickle danfickle mentioned this pull request Nov 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danfickle