fix bug when commiting .png files on BitBucket

danger · Apr 17, 2018 · 840867f · 840867f
1 parent 6f7d287
commit 840867f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,8 @@
 
 ## Master
 
+* fix bug when commiting .png files on BitBucket [@Mifi][]
+
 ## 3.4.7
 
 * Update dependencies [@orta][]
@@ -144,7 +146,7 @@
 ## 3.1.8
 
 * Improvements to the Flow definition file. [@orta][]
-* Improve path generator for danger-runner.
+* Improve path generator for danger-runner. [@Mifi][]
 * Update the PR DSL to include bots. [@orta][]
 
 ## 3.1.7
@@ -1039,7 +1041,7 @@ Not usable for others, only stubs of classes etc. - [@orta][]
 [@hongrich]: https://github.com/hongrich
 [@peterjgrainger]: https://github.com/peterjgrainger
 [@azz]: https://github.com/azz
-[@mifi]: https://github.com/ionutmiftode
+[@Mifi]: https://github.com/ionutmiftode
 [@sunshinejr]: https://github.com/sunshinejr
 [@mxstbr]: https://github.com/mxstbr
 [@happylinks]: https://github.com/happylinks

diff --git a/source/platforms/bitbucket_server/BitBucketServerGit.ts b/source/platforms/bitbucket_server/BitBucketServerGit.ts
@@ -37,15 +37,15 @@ function bitBucketServerCommitToGitCommit(
     },
     committer: bbsCommit.committer
       ? {
-          email: bbsCommit.committer.emailAddress,
-          name: bbsCommit.committer.name,
-          date: new Date(bbsCommit.committerTimestamp).toISOString(),
-        }
+        email: bbsCommit.committer.emailAddress,
+        name: bbsCommit.committer.name,
+        date: new Date(bbsCommit.committerTimestamp).toISOString(),
+      }
       : {
-          email: bbsCommit.author.emailAddress,
-          name: bbsCommit.author.name,
-          date: new Date(bbsCommit.authorTimestamp).toISOString(),
-        },
+        email: bbsCommit.author.emailAddress,
+        name: bbsCommit.author.name,
+        date: new Date(bbsCommit.authorTimestamp).toISOString(),
+      },
     message: bbsCommit.message,
     tree: null,
     url,
@@ -101,7 +101,7 @@ const bitBucketServerDiffToGitStructuredDiff = (diffs: BitBucketServerDiff[]): G
   return diffs.map(diff => ({
     from: diff.source && diff.source.toString,
     to: diff.destination && diff.destination.toString,
-    chunks: diff.hunks.map(hunk => ({
+    chunks: diff.hunks && diff.hunks.map(hunk => ({
       changes: hunk.segments.map(segment => ({
         type: segment.type === "ADDED" ? ("add" as "add") : ("del" as "del"),
         content: segment.lines.map(({ line }) => line).join(EOL),