Use spawn in danger local

source/commands/danger-local.ts

@@ -16,7 +16,6 @@ interface App extends SharedCLI {
 
 program
   .usage("[options]")
-  .option("-b, --base  [base]", "Choose the base commit to work against.")
   // TODO: this option
   // .option("-s, --staging", "Just use staged changes.")
   .description("Runs danger without PR metadata, useful for git hooks.")

source/platforms/git/localGetCommits.ts

@@ -22,10 +22,9 @@ export const formatJSON = `{ "sha": "${sha}", "parents": "${parents}", ${author}
 
 export const localGetCommits = (base: string, head: string) =>
   new Promise<GitCommit[]>(done => {
-    const call = `git log ${base}...${head} --pretty=format:'${formatJSON}'`
-    d(call)
-    const child = spawn(call)
-
+    const args = ["log", `${base}...${head}`, `--pretty=format:${formatJSON}`]
+    const child = spawn("git", args, { env: process.env })
+    d("> git", args.join(" "))
     child.stdout.on("data", async data => {
       data = data.toString()
 

source/platforms/git/localGetDiff.ts

@@ -1,20 +1,22 @@
 import { debug } from "../../debug"
-import { exec } from "child_process"
+import { spawn } from "child_process"
 
 const d = debug("localGetDiff")
 
 export const localGetDiff = (base: string, head: string) =>
   new Promise<string>(done => {
-    const call = `git diff ${base}...${head}`
-    d(call)
+    const args = ["diff", `${base}...${head}`]
 
-    exec(call, (err, stdout, _stderr) => {
-      if (err) {
-        console.error(`Could not get diff from git between ${base} and ${head}`)
-        console.error(err)
-        return
-      }
+    const child = spawn("git", args, { env: process.env })
+    d("> git", args.join(" "))
 
-      done(stdout)
+    child.stdout.on("data", async data => {
+      data = data.toString()
+      done(data)
+    })
+
+    child.stderr.on("data", data => {
+      console.error(`Could not get diff from git between ${base} and ${head}`)
+      throw new Error(data.toString())
     })
   })