Consolidate and apply tests to the GitHub API object

[orta]

It's a bit of a mess in there:

some return JSON

  async getUserInfo(): Promise<any> {
    const response: any = await this.get("user")
    return await response.json()
  }

async getReviewerRequests(): Promise<any> {
    const repo = this.ciSource.repoSlug
    const prID = this.ciSource.pullRequestID
    const res = await this.get(`repos/${repo}/pulls/${prID}/requested_reviewers`, {
      accept: "application/vnd.github.black-cat-preview+json"
    })
    if (res.ok) {
      return res.json()
    }
    return []
  }

some return the fetch call

  getPullRequestDiff(): Promise<any> {
    const repo = this.ciSource.repoSlug
    const prID = this.ciSource.pullRequestID
    return this.get(`repos/${repo}/pulls/${prID}`, {
      accept: "application/vnd.github.v3.diff"
    })
  }

some return a string

  async fileContents(path: string, ref?: string): Promise<string> {
    // Use head of PR (current state of PR) if no ref passed
    if (!ref) {
      const pr = await this.getPullRequestInfo()
      const prJSON = await pr.json()

      ref = prJSON.head.ref
    }
    const fileMetadata = await this.getFileContents(path, ref)
    const data = await fileMetadata.json()
    const buffer = new Buffer(data.content, "base64")
    return buffer.toString()
  }

and the names of the functions don't really mean too much. Perhaps the answer is that the the verb is put before, then the return type at the end: turning getReviewerRequests into getReviewerRequestsJSON. It may make sense to consider that two functions:

async getReviewerRequests(): Promise<any> {
    const repo = this.ciSource.repoSlug
    const prID = this.ciSource.pullRequestID
    return await this.get(`repos/${repo}/pulls/${prID}/requested_reviewers`, {
      accept: "application/vnd.github.black-cat-preview+json"
    })
}

async getReviewerRequestsJSON(): Promise<any> {
    const res =  await this.getReviewerRequests()
    if (res.ok) {
      return res.json()
    }
    return []
}

[deecewan]

my thoughts would be to:

• only return JSON. The Github API returns JSON for everything.
• error handling should be done inside the API call (I kinda made a move at this by testing res.ok in the reviewerRequests call

[alex3165]

PR up #173