Updates PR to green

[orta]

Gets this green - danger#156

I moved the DSL attributes for reviews into the root of the github DSL object, I agree with what you were doing, but it's probably better in the long run that we keep the PR metadata exactly what GitHub gives you ( then it can grow organically as/if GitHub makes changes to the response JSON.

That meant that the test which failed doesn't fail anymore. This is good and bad, so I made danger#164 and danger#163 to try make sure that it fails when we make big changes like that

[orta]

a bunch of the commits are from my work on danger#161 which is now in master

[deecewan]

thanks so much for this.

I put reviews/reviewComments into the PR, because that's where they exist inside the the API response. But I'm happy with the change.

[orta]

ohhh, they do do they, hrm - wonder if it's worth moving them back

[orta]

shoulda read all my comments

[deecewan]

yeah, i'm not sure either way. It seems semantic to have them inside of the PR, because they are reviews for the PR. On the other hand, maybe people don't expect it to be in there?

[orta]

I try to keep it as close to the actual response from GH as possible, so if they're there, then we should replicate it IMO

There'll be a pretty solid reference website from all the JSDoc stuff in a couple of months from now, so discoverability shouldn't be an issue IMO

[deecewan]

okay, awesome. i agree then, let's emulate the response. I was actually going to ask about a reference site, but that answers the question.

just FYI, there are a lot of overlaps between PR and issues. So the only things that I exposed in issues were the things that weren't in PRs, which is essentially just Labels. I'm not sure how you want to handle that.

[orta]

WRT the issues, that's a great question, maybe it's worth providing the full object also, but providing only the interface for the useful bits like labels? Then we don't need to chop it up, and if something useful is added in the future at least we've got it available form day 1.

[deecewan]

Yeah, that's a good call actually. I like that.