-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow access to the issue behind a PR #156
Conversation
update from origin
Generated by 🚫 dangerJS |
Sorry, I'm my honeymoon - so it's taking a while to get around to looking at all these PRs - but my wife is asleep, and I got some time, so I'll clone this and see if I can grok what's up with the tests |
no rush. enjoy yourself :) i haven't had time either. i'll take a look when I have a minute if you don't get round to it. |
cool, looks like these functions need to be mocked out in some existing tests, and ideally adding some to cover the API calls, will add them |
@orta I'm returning from a five-week hiatus, so I'll look to get involved in open issues and PRs over the course of this work week. Hope you have a great honeymoon! |
Rock - @deecewan I sent you a PR to your branch (you might not be watching your own repo) with a bunch of fixes here 👍 |
you're something special @orta. |
Updates PR to green
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 3 3
Lines 93 93
Branches 17 17
=====================================
Misses 93 93 Continue to review full report at Codecov.
|
OK, this is good to go |
👍 you're welcome @deecewan |
Now, users can access
danger.github.issue
to check if labels are applied, etc.There is not much in an issue that isn't in a PR, so at the moment all the is under
issue
islabels
.This has expanded a little and also adds reviews and requested reviews, so users can make sure there is at least x reviewers requested/made
Closes #154