Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to the issue behind a PR #156

Merged
merged 9 commits into from
Mar 14, 2017

Conversation

deecewan
Copy link
Member

@deecewan deecewan commented Mar 1, 2017

Now, users can access danger.github.issue to check if labels are applied, etc.

There is not much in an issue that isn't in a PR, so at the moment all the is under issue is labels.

This has expanded a little and also adds reviews and requested reviews, so users can make sure there is at least x reviewers requested/made

Closes #154

@DangerCI
Copy link

DangerCI commented Mar 3, 2017

Warnings
⚠️ Please add a changelog entry for your changes.

Generated by 🚫 dangerJS

@orta
Copy link
Member

orta commented Mar 12, 2017

Sorry, I'm my honeymoon - so it's taking a while to get around to looking at all these PRs - but my wife is asleep, and I got some time, so I'll clone this and see if I can grok what's up with the tests

@deecewan
Copy link
Member Author

deecewan commented Mar 12, 2017

no rush. enjoy yourself :)

i haven't had time either. i'll take a look when I have a minute if you don't get round to it.

@orta
Copy link
Member

orta commented Mar 12, 2017

cool, looks like these functions need to be mocked out in some existing tests, and ideally adding some to cover the API calls, will add them

@macklinu
Copy link
Member

@orta I'm returning from a five-week hiatus, so I'll look to get involved in open issues and PRs over the course of this work week. Hope you have a great honeymoon!

@orta
Copy link
Member

orta commented Mar 13, 2017

Rock - @deecewan I sent you a PR to your branch (you might not be watching your own repo) with a bunch of fixes here 👍

@deecewan
Copy link
Member Author

you're something special @orta.

@codecov-io
Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #156   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           3      3           
  Lines          93     93           
  Branches       17     17           
=====================================
  Misses         93     93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8efdf2b...e885ffa. Read the comment docs.

@orta
Copy link
Member

orta commented Mar 14, 2017

OK, this is good to go

@orta orta merged commit ea74b18 into danger:master Mar 14, 2017
@orta
Copy link
Member

orta commented Mar 14, 2017

👍 you're welcome @deecewan

@orta orta mentioned this pull request Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants