-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unique identifier for danger-written comments? #269
Comments
There is always the "posted by danger" - could verify that that exists inside the comment before declaring it as one posted by the tool? |
Also HTML stays inside the text comment (even if it's not rendered by markdown) so adding a useful |
I guess this can be used, question is more about locating comment ID logics (
|
Perhaps then I think a mix of same user and a specific hidden marker which can be added into every comment from danger is optimal. |
@orta I'd 👍 with those idea. |
Due to private repo's limitation, I am currently using myself's github token to run danger instance (which post comments under my user). Which makes if I leave a comment before danger finishes run, danger will remove those comment and replace it into danger's results.
Is there way to make danger validate comments (like having some prefix in comments?) to avoid these cases?
The text was updated successfully, but these errors were encountered: