Fix danger to lookup comment for its own only #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates logics of
getDangerCommentID
, in addition to look up userid of given danger token but also looks for comment body if it has comment signature written via danger. For cases of user shares token for danger runner, it'll prevent comment is being deleted by danger looks up comment not written by itself.Instead of introducing new hidden comment identifier, I took simple paths of looking signature directly (including HTML tags), which is sufficiently unique that individual user won't write those in their own comment.