Warn if changes to package.json and not yarn.lock #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on jestjs/jest#2508 This would have applied to #101
|
I force pushed up an amended commit that would fix the build, but GitHub doesn't seem to be aware of that amended commit yet. Will check back later. EDIT: nevermind, it's showing up now! |
macklinu
force-pushed
the
package-json-yarn-lock-warning
branch
from
96242d8
to
c06c20c
Compare
macklinu
commented
Jan 17, 2017
| @@ -1,5 +1,6 @@ | |||
| // import { danger, warn } from "danger" | |||
| import fs from "fs" | |||
| import includes from "lodash.includes" | |||
There was a problem hiding this comment.
Do we need to worry about Node 4 support, or should I just use the built-in Array.prototype.includes() function here?
|
It looks like there are Appveyor builds queueing up too. I logged in with GitHub but don't see a button to cancel old builds.
|
|
Yeah, I've been seeing it on other repos - I'm cool with merging without it and yeah, I don't think TS backports the includes function, so best use the loads version IMO |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#trivial
Based on jestjs/jest#2508
This would have applied to #101 (discovered when I merged master into and ran
yarn installon #99).