Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't output table if no violations are specified #116

Merged
merged 5 commits into from
Jan 29, 2017
Merged

Don't output table if no violations are specified #116

merged 5 commits into from
Jan 29, 2017

Commits on Jan 29, 2017

  1. Don't output table if no violations are specified 

    Right now when using `fail` just to fail the build, but not to output
any information (i.e. just using `fail()`), Danger outputs an empty
table with a message of "undefined", which is annoying. (see danger#109 for
context)

I _think_ this fixes it, but I'm not sure if it's the right fix and/or
if there's a better way to do it. Please let me know!
    @mxstbr
    mxstbr committed Jan 29, 2017
    Configuration menu
    Copy the full SHA
    28a8f60 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @mxstbr
    mxstbr committed Jan 29, 2017
    Configuration menu
    Copy the full SHA
    c9b9d7f View commit details
    Browse the repository at this point in the history

  3. Add tests for new behaviour

    @mxstbr
    mxstbr committed Jan 29, 2017
    Configuration menu
    Copy the full SHA
    daa8c73 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG

    @mxstbr
    mxstbr committed Jan 29, 2017
    Configuration menu
    Copy the full SHA
    cddd762 View commit details
    Browse the repository at this point in the history

  5. Fix for multiple empty results

    @mxstbr
    mxstbr committed Jan 29, 2017
    Configuration menu
    Copy the full SHA
    f156775 View commit details
    Browse the repository at this point in the history