Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Buildkite #220

Merged
merged 3 commits into from
Apr 13, 2017
Merged

Add support for Buildkite #220

merged 3 commits into from
Apr 13, 2017

Conversation

jacobwgillespie
Copy link
Member

@jacobwgillespie jacobwgillespie commented Apr 13, 2017

This PR adds support for Buildkite as a CI source, including tests.

@jacobwgillespie
Copy link
Member Author

jacobwgillespie commented Apr 13, 2017

I think the tests should be passing, but it looks like AppVeyor cannot connect to github.com (SSL error). They're passing on Travis.

@macklinu macklinu requested review from gabro and removed request for gabro April 13, 2017 15:50
Copy link
Member

@macklinu macklinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for your contribution, @jacobwgillespie! 🎉 The Appveyor issue seems like a fluke; I feel comfortable merging this as is with the passing Travis build. 👍

@macklinu macklinu merged commit c84a243 into danger:master Apr 13, 2017
@jacobwgillespie jacobwgillespie deleted the buildkite branch April 13, 2017 15:53
@jacobwgillespie
Copy link
Member Author

Thanks, happy to contribute! 🚀

@orta
Copy link
Member

orta commented Apr 13, 2017

Awesome - thanks @jacobwgillespie

also, I've invited you to the org, as a part of Moya Community Continuity - you're welcome to participate (or not) in PRs and help out at a level that works for you.

@jacobwgillespie
Copy link
Member Author

Awesome! Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants