-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for circle ci #32
Conversation
This is very much similar to the travis tests, but with env vars updated to match circle env var settings (and not the almighty word of Josh). Adds jest tests for a circle env.
i have a followup to this pr at nsfmc#2 which gets flow linting correctly on circle (the ignore flag isn't working on flow 0.32.0 on circle at least) |
yeahhhhhh |
this all looks super awesommme |
OK, I've turned Circle on for this repo - looks all perfect to me 👍 |
Would you like to join the org @nsfmc - we invite anyone who has sent a PR? |
Yeah, the Flow 0.35 one looks like a 10/10 PR too - that was on my TODO list once I wrap up an artsy project |
@orta yeah would love to be added, not sure what the extent of my contributions will be, for now just integrating with our project repo at work and trying to achieve stability. |
No pressure or expectations to work on the project,t it just gives you the ability to be a bit more in control of your destiny if you need it 👍 |
Adds in support for detecting a circle ci environment. this is running side-by-side here nsfmc#1 (apologies for any noise)