Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back relative files #359

Closed
wants to merge 3 commits into from
Closed

Bring back relative files #359

wants to merge 3 commits into from

Conversation

orta
Copy link
Member

@orta orta commented Aug 28, 2017

Again, as with #355 I'm a bit confused that this seemed to just work...

@DangerCI
Copy link

Fails
🚫

Danger failed to run dangerfile.ts.

Error VMError

Cannot find module './scripts/danger-dts'
VMError: Cannot find module './scripts/danger-dts'
    at _require (/home/travis/build/danger/danger-js/node_modules/vm2/lib/sandbox.js:234:25)
    at Object.<anonymous> (/home/travis/build/danger/danger-js/dangerfile.ts:75:20)
    at NodeVM.run (/home/travis/build/danger/danger-js/node_modules/vm2/lib/main.js:424:27)
    at Object.<anonymous> (/home/travis/build/danger/danger-js/distribution/runner/DangerfileRunner.js:139:24)
    at step (/home/travis/build/danger/danger-js/distribution/runner/DangerfileRunner.js:40:23)
    at Object.next (/home/travis/build/danger/danger-js/distribution/runner/DangerfileRunner.js:21:53)
    at /home/travis/build/danger/danger-js/distribution/runner/DangerfileRunner.js:15:71
    at Promise (<anonymous>)
    at __awaiter (/home/travis/build/danger/danger-js/distribution/runner/DangerfileRunner.js:11:12)
    at Object.runDangerfileEnvironment (/home/travis/build/danger/danger-js/distribution/runner/DangerfileRunner.js:127:12)

Dangerfile

----------------------------^

Generated by 🚫 dangerJS

@orta
Copy link
Member Author

orta commented Aug 28, 2017

Interesting, the tests pass, but the real life example fails - I bet this is due to jest and jest's typescript support.

@orta
Copy link
Member Author

orta commented Sep 19, 2017

Fixed in #378

@orta orta closed this Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants