Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a generated project for testing non-babel + babel projects #360

Merged
merged 2 commits into from
Sep 3, 2017

Conversation

orta
Copy link
Member

@orta orta commented Aug 29, 2017

I'd like something to ensure that a project without babel or typescript works, it's looking like it's going to be hard to test that in the form of unit tests, so I've moved it up to integration tests.

This creates a new project, adds Danger, then runs it with no babel/typescript.

@orta orta changed the title Adds a generated project for testing non-babel projects Adds a generated project for testing non-babel + babel projects Aug 30, 2017
@orta orta force-pushed the test_simple branch 2 times, most recently from 8e5ab14 to 7e1c52c Compare August 30, 2017 00:33
@orta
Copy link
Member Author

orta commented Aug 30, 2017

It's great, and super frustrating - why can't I get the re-pro of styled-components/styled-components#1122

@orta
Copy link
Member Author

orta commented Sep 3, 2017

I mean, I added a babel Dangerfile to danger-plugin-spellcheck and it worked orta/danger-plugin-spellcheck#8

@orta orta merged commit f4bd696 into master Sep 3, 2017
@orta orta deleted the test_simple branch September 3, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant