Include created and removed files for diffForFile, JSONDiffForFile, JSONPatchForFile

[bdotdub]

• Implementation for: GitDSL: Diffs for added and removed files #368

Functions

• diffForFile
• JSONPatchForFile
• JSONDiffForFile

[orta]

This is looking sweeeeeeet 👍

[bdotdub]

@orta Would love to get your thoughts here.

For created files, I think it makes sense to have before return null since the before is the absence of the file. The diff is technically correct to, but feel unexpected and/or inconsistent with other behavior.

What do you think about JSONPatchForFile returning null for before, but the diff as the result between {} and after?

So instead of this:

{
  "op": "replace",
  "path": "",
  "value": {
    "a": "o, world",
    "b": 3,
    "c": ["one", "two", "three", "four"],
  }
}

it becomes this:

[
  {
    "op": "add",
    "path": "/a",
    "value": "o, world"
  },
  {
    "op": "add",
    "path": "/b",
    "value": 3
  },
  {
    "op": "add",
    "path": "/c",
    "value": [
      "one",
      "two",
      "three",
      "four"
    ]
  }
]

While not technically correct, I think it makes more sense semantically.

[orta]

I agree 👍

[bdotdub]

@orta I think this is ready! 👌

[orta]

Awesome, amazing and beautifully tested 👍

[orta]

Shipped as Danger 2.0a15