Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test errors on Windows relating to line-endings. #468

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

jchv
Copy link
Contributor

@jchv jchv commented Jan 3, 2018

This attempts to resolve an issue with running tests on Windows machines that have core.autocrlf set to true (default.)

Issue: #467

@jchv jchv changed the title Fix test errors on Windows relating to line-endings. (Issue #467) Fix test errors on Windows relating to line-endings. Jan 3, 2018
@DangerCI
Copy link

DangerCI commented Jan 3, 2018

Warnings
⚠️

Expect 2 warnings

⚠️

the other

Generated by 🚫 dangerJS

@orta
Copy link
Member

orta commented Jan 3, 2018

Awesome! Thanks!

@orta orta merged commit 67af84b into danger:master Jan 3, 2018
@peril-staging
Copy link
Contributor

peril-staging bot commented Jan 3, 2018

Thanks for the PR @jchv.

We conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks 🎉

Generated by 🚫 dangerJS

@peril-staging
Copy link
Contributor

peril-staging bot commented Jan 3, 2018

Thanks for the PR @jchv.

This PR has been shipped in v3.0.0 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants