Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the danger invocation isn't straight danger #472

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

hawkrives
Copy link
Contributor

Addresses #470

Checks that the danger command was invoked by way of some subcommand.

@orta
Copy link
Member

orta commented Jan 5, 2018

I did not know about the sum function, damn, I could have wrote a lot of code better with that 👍

@orta orta merged commit fcded8d into danger:master Jan 5, 2018
@orta
Copy link
Member

orta commented Jan 5, 2018

Thanks @hawkrives

@peril-staging
Copy link
Contributor

peril-staging bot commented Jan 5, 2018

Thanks for the PR @hawkrives.

We conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks 🎉

Generated by 🚫 dangerJS

@orta
Copy link
Member

orta commented Jan 6, 2018

Tested this locally, because commander mutates process.env this didn't work - fixed it in #469

@hawkrives
Copy link
Contributor Author

Oh right, you mentioned that. Thanks.

@peril-staging
Copy link
Contributor

peril-staging bot commented Jan 6, 2018

Thanks for the PR @hawkrives.

This PR has been shipped in v3.0.1 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants