Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --base option for danger local cli #506

Merged
merged 2 commits into from
Feb 5, 2018
Merged

Conversation

peterjgrainger
Copy link

Fixed #496

@peterjgrainger
Copy link
Author

I see the test failing, i'll try to recreate locally

@peterjgrainger
Copy link
Author

peterjgrainger commented Feb 5, 2018

@orta A previous build fails on the same issue https://travis-ci.org/danger/danger-js/jobs/336976131, I think this test fails if git log master...HEAD has no history i.e. HEAD === master

Let me know if I need to change anything. I believe everything is working as it is supposed to.

@orta
Copy link
Member

orta commented Feb 5, 2018

Yeah, that's something I've wanted to fix but haven't (been working on danger/peril#159 for the last few weeks straight) I was going to add a check if head === master just exit with 0 and give a log saying "doing nothing"

@orta
Copy link
Member

orta commented Feb 5, 2018

Looks 👍 regardless :D

@orta orta merged commit a59c08a into danger:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants