Add Bitbucket Server Support #516

azz · 2018-02-17T13:30:12Z

Closes #515

Still a bunch of things to do but it is starting to take shape.

TODO:

Write tests
Implement getPullRequestDiff - Not sure if there's a way to download the raw patch...
Format in Markdown rather than HTML
Manual test build status
Manual test comment placement, update, delete
Documentation

azz · 2018-02-17T13:31:26Z

source/platforms/bitbucket_server/BitBucketServerAPI.ts

+  }
+
+  getPullRequestDiff = async () => {
+    // TODO: possible?


Can't seem to find an endpoint to get a raw diff, but there's a structured version in the REST API. Could use that but would require changing some common code.

OK, I'm reasonably sure the two underlying features that rely on this are:

Finding out the modified/created/deleted files

Generating metadata for a specific file (e.g. maybe a JSON diff, or showing before after etc)

There may be two different APIs that could get that kind of information from?

orta · 2018-02-17T13:37:07Z

Wow, first of all, awesome 👍

orta · 2018-02-17T13:54:22Z

Might be about an hour or two before I can think properly about this

azz · 2018-02-17T13:55:40Z

No worries - I need to take a break so I'll pick this up again tomorrow.

orta

Yep, this is definitely the right way to do this

orta · 2018-02-17T14:54:45Z

source/danger.d.ts

+      href: string
+      name?: string
+    }[]
+  }


orta · 2018-02-17T14:55:45Z

source/dsl/BitBucketServerDSL.ts

+// This is `danger.bitbucket_server`
+
+/** The BitBucketServer metadata for your PR */
+export interface BitBucketServerDSL extends BitBucketServerJSONDSL {}


if/once you start getting some helper functions in the bitbucket DSL, that's where this comes in handy.

orta · 2018-02-17T14:56:09Z

source/dsl/BitBucketServerDSL.ts

+export interface JIRAIssue {
+  key: string
+  url: string
+}


This is cool

orta · 2018-02-17T14:58:48Z

source/dsl/BitBucketServerDSL.ts

+  locked: boolean
+  author: BitBucketServerPRParticipant & { role: "AUTHOR" }
+  reviewers: (BitBucketServerPRParticipant & { role: "REVIEWER" })[]
+  participants: (BitBucketServerPRParticipant & { role: "PARTICPANT" })[]


Nice typing work

orta · 2018-02-17T15:00:57Z

source/platforms/BitBucketServer.ts

+  createComment = (comment: string) => this.api.postPRComment(comment)
+
+  // In Danger RB we support a danger_id property,
+  // this should be handled at some point


This is handled, I should remove the comment

orta · 2018-02-17T15:11:42Z

yarn.lock

@@ -1371,9 +1371,9 @@ cli-spinners@^0.1.2:
  version "0.1.2"
  resolved "https://registry.yarnpkg.com/cli-spinners/-/cli-spinners-0.1.2.tgz#bb764d88e185fb9e1e6a2a1f19772318f605e31c"


ah, I bet this is me accepting greenkeeper PRs

azz · 2018-02-18T03:43:51Z

Not nearly as pretty as GitHub 😢, but it works!

azz · 2018-02-18T04:22:57Z

Since BitBucket server doesn't support HTML in markdown, I've replaced the table with a list of blockquotes, otherwise the warnings cannot be multi-line.

azz · 2018-02-18T04:50:07Z

Build Status works:

azz · 2018-02-18T09:41:18Z

danger-js/source/ci_source/providers/Travis.ts

Lines 55 to 57 in 6f1371d

    
           get supportedPlatforms() { 
        
             return ["github"] 
        
           }

Noticed this in all the ci_sources. But it doesn't seem to be used?

orta · 2018-02-18T12:23:52Z

re:

get supportedPlatforms()

Yeah, so only certain CI sources will support things like GitLab/BB/BBS - for example TeamCity supports GH/GitLab/BB/BBS in Ruby: code

So you can verify that the CI hooks up to the platform, but TBH, it might not need it, considering that the ENV vars added must mean that someone knows it will work, so maybe the abstraction isn't needed?

orta · 2018-02-18T12:28:19Z

Re: the comment, tricky yeah. Another option is to do some funky markdown by adding line separators between the HTML content and the markdown

<table>
  <thead>
    <tr>
      <th width="5%"></th>
      <th width="95%" data-danger-table="true">Header</th>
     </tr>
  </thead>
  <tbody>
    <tr>
      <td>:+1:</td>
      <td>

some [markdown](/link)

    </td>
    </tr>
  </tbody>
</table>

	Header
👍	some markdown

Which is the trick used in the gitlab markdown renderer for GitLab + BBS in Ruby

azz · 2018-02-18T22:34:04Z

It doesn't seem to support any HTML at all. :(

orta · 2018-02-19T00:00:23Z

Yeah, true that, I found the template: https://github.com/danger/danger/blob/132c5d1a415656bee49d451b861569a6a08cfc30/lib/danger/comment_generators/bitbucket_server.md.erb#L1-L20

azz · 2018-02-23T12:14:17Z

(not sure what happened with that merge commit, will have to roll back)

orta · 2018-02-23T15:25:00Z

The above message is an integration test that should only sending its messages to STDOUT btw, if you're wondering wha could have triggered it

azz · 2018-02-24T05:57:55Z

source/platforms/bitbucket_server/BitBucketServerGit.ts

+  return diffs.map(diff => ({
+    from: diff.source && diff.source.toString,
+    to: diff.destination && diff.destination.toString,
+    chunks: diff.hunks.map(hunk => ({


I have no idea what the difference between a hunk and a chunk is...

All the pieces needed for a male model catalogue

azz · 2018-02-24T11:15:14Z

I think all the functionality is done. I'll start writing tests tomorrow and look at documentation.

azz · 2018-02-25T08:46:36Z

Added tests. 🔬

azz · 2018-02-25T09:57:15Z

@orta know what's up with this build?

🔗 https://travis-ci.org/danger/danger-js/jobs/345868483

orta · 2018-02-25T11:57:45Z

The TypeScript doesn't seem to compile, https://travis-ci.org/danger/danger-js/jobs/345868483#L593-L596

source/ci_source/providers/Nevercode.ts:46:15 - error TS6133: 'branchName' is declared but its value is never read.

Which cascades through some of the next tests.

orta · 2018-02-25T13:38:32Z

Wow @azz, this is so much work 👍

orta · 2018-02-25T16:15:50Z

I've got it green, and extended the DSL with some JSDocs

azz · 2018-02-26T11:29:52Z

Awesome, I'll try and find some time in the next few days to write docs and give it a test on a project at work.

orta · 2018-02-26T16:30:03Z

Cool cool, once you're happy with the docs in here I can go take it to the more gnarly getting started page

azz · 2018-03-04T01:28:47Z

Had a busy week at work and didn't get a chance to try it out! I'll try again early this coming week.

…tems

orta · 2018-03-11T17:07:56Z

OK @azz - I've gone and done a docs run, and prepared for it on the website too ( https://gitlab.com/danger-systems/danger.systems/merge_requests/168 )

Want to give me a lint for it all and say whether this is good to go?

zdnk · 2018-03-12T13:00:16Z

For some reason when installing from your branch I am not able to access danger command using yarn.

orta · 2018-03-12T13:44:07Z

It's probably not being compiled by TypeScript

zdnk · 2018-03-12T13:47:35Z

So how would I fix it? I am not JS dev, but really would like to adopt the JS version of danger with BBS support finally :)

orta · 2018-03-12T13:57:48Z

I'd wait TBH if you're not a JS dev, it shouldn't be too long

azz · 2018-03-14T21:27:33Z

👍 👍 👍

orta · 2018-03-15T02:02:29Z

ok, let's try get this rolling

langovoi · 2018-11-14T15:45:24Z

@azz i found that API /diff don't return diff for files in sub-sub-directory from root.

So modified_files, deleted_files and creates_files are wrong.

Do you have this problem with your Bitbucket Server? I could not find any information or issues about this bug/behavior.

azz commented Feb 17, 2018

View reviewed changes

orta reviewed Feb 17, 2018

View reviewed changes

azz force-pushed the bitbucket-server branch 2 times, most recently from 0301946 to 15f7428 Compare February 24, 2018 05:56

azz commented Feb 24, 2018

View reviewed changes

azz added 11 commits February 25, 2018 19:44

WIP: add bitbucket server support

ce8564c

Update types and CHANGELOG

7111b1d

Remove bad throw

a06ec3d

Get existing tests passing

251114d

It runs

2a8f9c5

Add template

310b865

Update declarations

3fce9a9

Improve template

c7608d7

Support getPullRequestIDForBranch

ca4b9ba

Fix build status

c5cf5b3

Improve formatting

b66d8bc

orta added 2 commits February 25, 2018 08:43

Remove unused function in nevercode

b9984c9

Extends the DSL with comments

491fd89

sunshinejr mentioned this pull request Mar 4, 2018

Inline mode. #529

Merged

13 tasks

orta and others added 5 commits March 11, 2018 08:45

Merge branch 'master' into bitbucket-server

d496f43

[init] Adds support for warning against non-github repos in danger init

9695179

[bbs] Adds some more docs

c914f2f

Removes the troubleshooting page, adds it as a redirect in danger.sys…

327231d

…tems

More docs

8105935

Merge master

2a0451c

orta merged commit 9bf089a into danger:master Mar 15, 2018

orta changed the title ~~WIP: Add Bitbucket Server Support~~ Add Bitbucket Server Support Mar 15, 2018

azz deleted the bitbucket-server branch March 15, 2018 08:51

stigi mentioned this pull request Apr 10, 2018

WIP: GitLab stigi/danger-js#1

Closed

jamime mentioned this pull request Jun 11, 2019

Using DangerJS with GitLab/BitBucket #396

Closed

		@@ -1371,9 +1371,9 @@ cli-spinners@^0.1.2:
		version "0.1.2"
		resolved "https://registry.yarnpkg.com/cli-spinners/-/cli-spinners-0.1.2.tgz#bb764d88e185fb9e1e6a2a1f19772318f605e31c"

Add Bitbucket Server Support #516

Add Bitbucket Server Support #516

Conversation

azz commented Feb 17, 2018 • edited by orta Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orta commented Feb 17, 2018

orta commented Feb 17, 2018

azz commented Feb 17, 2018

orta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azz commented Feb 18, 2018

azz commented Feb 18, 2018 • edited Loading

azz commented Feb 18, 2018 • edited Loading

azz commented Feb 18, 2018

orta commented Feb 18, 2018

orta commented Feb 18, 2018 • edited Loading

azz commented Feb 18, 2018

orta commented Feb 19, 2018

azz commented Feb 23, 2018

orta commented Feb 23, 2018

Choose a reason for hiding this comment

orta Feb 24, 2018 • edited Loading

Choose a reason for hiding this comment

azz commented Feb 24, 2018

azz commented Feb 25, 2018

azz commented Feb 25, 2018

orta commented Feb 25, 2018

orta commented Feb 25, 2018

orta commented Feb 25, 2018

azz commented Feb 26, 2018

orta commented Feb 26, 2018

azz commented Mar 4, 2018

orta commented Mar 11, 2018

zdnk commented Mar 12, 2018

orta commented Mar 12, 2018

zdnk commented Mar 12, 2018

orta commented Mar 12, 2018

azz commented Mar 14, 2018

orta commented Mar 15, 2018

langovoi commented Nov 14, 2018

azz commented Feb 17, 2018 •

edited by orta

Loading

azz commented Feb 18, 2018 •

edited

Loading

azz commented Feb 18, 2018 •

edited

Loading

orta commented Feb 18, 2018 •

edited

Loading

orta Feb 24, 2018 •

edited

Loading