Makes the Danger title come first, not last, in the std out #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, theoretically yes, but right now when you have a long build log it is a lot easier (at least for me) to find the summary - it's near end so you can quickly see the results. Edit: maybe a title before the log & summary at the end would be a good alternative? |
|
I agree, was thinking about this afterward, probably worth doing a check how many lines of text are in the violations, and if it's over ~10 have the message at the bottom |
|
Yeah, I like it more 👍 |
orta
commented
Apr 25, 2018
|
|
||
| const allMessages = [...fails, ...warnings, ...messages, ...markdowns].map(m => m.message) | ||
| const oneMessage = allMessages.join("\n") | ||
| const longMessage = oneMessage.split("\n").length > 30 |
There was a problem hiding this comment.
My laptop full screen is 40 lines, so this is 3/4 of that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
felt backwards