Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch github api error thrown from @octokit/rest #575

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Catch github api error thrown from @octokit/rest #575

merged 1 commit into from
Apr 27, 2018

Conversation

Teamop
Copy link
Contributor

@Teamop Teamop commented Apr 26, 2018

Fix #532
For the newly created files, api.repos.getContent(opts) will get a HttpError thrown by @octokit/rest, so here just try/catch them to catch the issue so that diffForFile can work well for these files

@Teamop Teamop changed the title Catch github api error return from @octokit/rest Catch github api error thrown from @octokit/rest Apr 26, 2018
@orta
Copy link
Member

orta commented Apr 27, 2018

Perfect, thanks!

@orta orta merged commit 4f74b42 into danger:master Apr 27, 2018
@Teamop Teamop deleted the catch-error branch April 28, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Teamop @orta