Support for the new GitHub Checks API #594
Conversation
|
New dependencies added: jsonwebtokenAuthor: auth0 Description: JSON Web Token implementation (symmetric and asymmetric) Homepage: https://github.com/auth0/node-jsonwebtoken#readme
@types/jsonwebtokenAuthor: Unknown Description: TypeScript definitions for jsonwebtoken Homepage: http://npmjs.com/package/@types/jsonwebtoken
|
orta
changed the title
|
Sidenote: it's possible that this next commit may break using the API with enterprise apps |
|
Somewhat blocked by https://github.com/octokit/rest.js/pull/866 and https://github.com/octokit/rest.js/pull/864 for the mo' - think I have all the data set up, will need to handle the API stuff once they're good |
|
This is great @orta, thanks for working on this so quickly! Really excited about that one, the integration looks awesome |
orta
force-pushed
the
checks
branch
3 times, most recently
from
8b87498 to
6105752
Compare
|
Got my first check working 👍 Was trivial work with octokit @gr2m |
| - echo "This is the real `danger ci` run on this repo" | ||
| - DEBUG="*" danger ci --verbose | ||
|
|
||
| # If the PR is odd then run using issue commenting, else use checks |
There was a problem hiding this comment.
Thanks man, yeah, I was thinking for a while on how I can ensure this is regularly integrated properly - love this hack, I've not yet got it working but I will get it eventually
|
This is really exciting. Too bad it's going to require such a tricky integration process :( |
|
Given the security model of GitHub Apps I can just give out both an app ID, and a private key with access to checks, people will only need to install it on their org and give danger the install ID. Could be less work in general. |
|
I went one better, it's way simpler to set up Danger now:
No faffing with making a new user, or new app. |
|
orta
changed the title
|
Alright, I'm shipping this so I can try it out in Peril. |
WIP on support for using GH checks - #592 danger/danger#984
For a normal Danger (only) run, then Danger will need to know the following:
Definitely not a blocker, but certainly a bit non-trivial. This is intended to be opt-in for Danger, and probably the default for Peril.
I intend do to it by refactoring the commenting aspect of the GitHub platform to either be the issue comment we have now, or via the checks API exclusively.