Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to babel 7 stable #662

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Update to babel 7 stable #662

merged 1 commit into from
Sep 13, 2018

Conversation

adamnoakes
Copy link
Contributor

@adamnoakes adamnoakes commented Sep 13, 2018

Updated to use preset-env with target of node 6 (i assume this is the lowest supported as jest won't run below 6). Ran the tests in a node 6 environment.

Not sure if this is major/ minor please advise and i'll update the changelog

@DangerCI
Copy link

Danger run resulted in 1 warning and 8 markdowns; to find out more, see the checks page.

Generated by 🚫 dangerJS

@cwright017
Copy link
Contributor

#662 #627

@orta
Copy link
Member

orta commented Sep 13, 2018

Aha, I see, so the runtime danger wouldn't support babel7 because of the require paths etc.

I think I'll go with a semantic version major bump here. Existing installs may have different behavior after updating.

Thanks!

@orta orta merged commit b2366f8 into danger:master Sep 13, 2018
@orta
Copy link
Member

orta commented Sep 13, 2018

I'll handle the changelog with the release, don't worry about it 👍

@peril-staging
Copy link
Contributor

peril-staging bot commented Sep 13, 2018

Thanks for the PR @adamnoakes.

The Danger org conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks adamnoakes 🎉

Generated by 🚫 dangerJS

@peril-staging
Copy link
Contributor

peril-staging bot commented Sep 13, 2018

Thanks for the PR @adamnoakes.

This PR has been shipped in v4.0.0 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants