Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables ES module interoperability + upgrades jest & ts-jest #668

Merged
merged 3 commits into from
Sep 20, 2018

Conversation

huafu
Copy link
Contributor

@huafu huafu commented Sep 20, 2018

With typescript 2.7 came esModuleInterop option which allows to use import foo from 'foo' for both ES modules and CommonJS ones (read more there)

This PR:

  • enables esModuleInterop and fixes imports related to this
  • updates jest, ts-jest and typescript
  • fixes all typing issues in tests (unused params, wrong typings, unused imports, ...)

Implicitly it'll fix #667

@DangerCI
Copy link

Danger run resulted in 1 warning and 2 markdowns; to find out more, see the checks page.

Generated by 🚫 dangerJS

@orta
Copy link
Member

orta commented Sep 20, 2018

Nice! Yeah, this looks 👍

@orta
Copy link
Member

orta commented Sep 20, 2018

Thanks a lot!

@orta orta merged commit 4100842 into danger:master Sep 20, 2018
@peril-staging
Copy link
Contributor

peril-staging bot commented Sep 20, 2018

Thanks for the PR @huafu.

The Danger org conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks huafu 🎉

Generated by 🚫 dangerJS

@huafu huafu deleted the fix-ts-issues branch September 20, 2018 11:53
@peril-staging
Copy link
Contributor

peril-staging bot commented Sep 22, 2018

Thanks for the PR @huafu.

This PR has been shipped in v4.0.2 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An in-range update of ts-jest is breaking the build 🚨
3 participants