Add Proxy support

[steprescott]

This PR adds the ability to proxy any of the network requests made by danger to be proxied.

It uses the standard HTTP_PROXY & HTTPS_PROXY environment variables and if either of them is set will then proxy those requests.

To ensure the tests pass a server is created so the request can be handled but dose no assertion to ensure the request was proxied. The only addition I have added is adding the Agent to the request and so I have only tested that an Agent is set on the request, not that the request can be successfully proxied as that should be covered by the http-proxy-agent package.

However when running danger pr with either HTTP_PROXY or HTTPS_PROXY set I can see that the requests are being proxied via Charles.

More details can be found here.

[DangerCI]

New dependencies added: @types/http-proxy-agent.

@types/http-proxy-agent

Author: Unknown

Description: TypeScript definitions for http-proxy-agent

Homepage: http://npmjs.com/package/@types/http-proxy-agent

Created	11 months ago
Last Updated	2 days ago
License	MIT
Maintainers	1
Releases	2
Direct Dependencies	@types/node

README

Installation

npm install --save @types/http-proxy-agent

Summary

This package contains type definitions for http-proxy-agent (https://github.com/TooTallNate/node-http-proxy-agent).

Details

Files were exported from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/http-proxy-agent

Additional Details

• Last updated: Wed, 17 Oct 2018 16:01:04 GMT
• Dependencies: node
• Global values: none

Credits

These definitions were written by mrmlnc https://github.com/mrmlnc, steprescott https://github.com/steprescott.

Generated by 🚫 dangerJS

[orta]

I think you just removed this dependency by accident

[steprescott]

Oh I thought by including @types/http-proxy-agent this was no longer needed. It builds & the tests pass so I'm confused. Is this needed? Happy to revert this line.

[orta]

It's needed - the @types go in dev dependencies and will only occur in this repo. Not in a consumer of danger

[orta]

Other than that - looks good to me

[steprescott]

Thanks for the review. I've acted on your comments. Any more issue let me know. Once this is in I will look at adding the same change to Peril.

[orta]

👍

[peril-staging]

Thanks for the PR @steprescott.

The Danger org conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks steprescott 🎉

Generated by 🚫 dangerJS

[peril-staging]

Thanks for the PR @steprescott.

This PR has been shipped in v4.4.10 - CHANGELOG.