Multiline Danger Imports/Requires Fixes #829 #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great tests, yeah, this makes senes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #829 I found a case where prettier would break my danger file by forcing my import onto two lines.
I fiddled with the regexes that were nuking the danger-imports and added more test cases to the test suite.
I'm no expert at Regex -- please feel free to improve their efficiency / clarity!
Additionally, this attempts to preserve the original source code, with the hope that DangerJS Error messages will appear on the correct "original source" lines. (I admit to doing nothing to verify this).
Finally, this PR changes this test from manually coded result-strings to Jest's new-ish
toMatchInlineSnapshotAPI.