Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test for avro producer #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

claudio-benfatto
Copy link

This PR fixes the failing test for the Avro producer:

--- FAIL: TestAvroProducer_Add (0.00s)
    avroProducer_test.go:17: Error adding msg: unexpected end of JSON input
    sync_producer.go:115: Expected to exhaust all expectations, but 1 are left.

due to not matching request url with the POST switch case of the createSchemaRegistryTestObject switch

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #8 into master will decrease coverage by 3.92%.
The diff coverage is 22.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   61.66%   57.73%   -3.93%     
==========================================
  Files           5        5              
  Lines         253      265      +12     
==========================================
- Hits          156      153       -3     
- Misses         75       90      +15     
  Partials       22       22              
Impacted Files Coverage Δ
avroConsumer.go 17.24% <ø> (ø)
cachedSchemaRegistry.go 85.10% <ø> (ø)
schemaRegistry.go 78.00% <ø> (ø)
avroProducer.go 36.53% <22.72%> (-18.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51334c9...d7a2304. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant