Skip to content

Commit

Permalink
fix issue with adding ciphers to organizations on native ios app (#4800)
Browse files Browse the repository at this point in the history
* add organizationID alias for native ios

* add reverse sanity check
  • Loading branch information
stefan0xC authored Jul 30, 2024
1 parent d335187 commit 7c8ba0c
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/api/core/ciphers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ pub struct CipherData {
// Folder id is not included in import
folder_id: Option<String>,
// TODO: Some of these might appear all the time, no need for Option
#[serde(alias = "organizationID")]
pub organization_id: Option<String>,

key: Option<String>,
Expand Down Expand Up @@ -286,6 +287,10 @@ async fn post_ciphers_create(
if data.cipher.organization_id.is_some() && data.collection_ids.is_empty() {
err!("You must select at least one collection.");
}
// reverse sanity check to prevent corruptions
if !data.collection_ids.is_empty() && data.cipher.organization_id.is_none() {
err!("The client has not provided an organization id!");
}

// This check is usually only needed in update_cipher_from_data(), but we
// need it here as well to avoid creating an empty cipher in the call to
Expand Down

0 comments on commit 7c8ba0c

Please sign in to comment.