Fix collection update from native client #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some strange reason the native clients send `CollectionIds` instead of `collectionIds` for updating the collection. Added an alias to allow this. Fixes an issue reported via Matrix. Signed-off-by: BlackDex <black.dex@gmail.com>
dani-garcia
approved these changes
Sep 10, 2024
|
Shall we release a new version for it? Since the latest native client with version 2024.8.1(19099) could not connect to the vaultwarden v1.32.0. |
|
We will, but there still seem to be some users having issue connecting even when using a version with this patch. So before we release a new one, we want to tackle that too. |
rkube-rvk
pushed a commit
to reveko/vaultwarden
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some strange reason the native clients send
CollectionIdsinstead ofcollectionIdsfor updating the collection. Added an alias to allow this.Fixes an issue reported via Matrix.