Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --version from failing without config #5055

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fix --version from failing without config #5055

merged 2 commits into from
Oct 11, 2024
+12 −4

Commits on Oct 11, 2024

  1. Fix --version from failing without config 

    Since we added the option to show the web-vault version also when running `--version` this causes the config to always be validated.
While this is not very bad in general, it could cause the command to quit during the config validation, and not show the version, but also errors.
This is probably not very useful for this specific command, unlike the `--backup` for example.

To fix this, and preventing the config from being validated, i added an AtomicBool to check if we need to validate the config on first load.
This prevents errors, and will just show the Vaultwarden version, and if possible the web-vault version too.

Fixes dani-garcia#5046

Signed-off-by: BlackDex <black.dex@gmail.com>
    @BlackDex
    BlackDex committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ad70e59 View commit details
    Browse the repository at this point in the history

  2. Adjusted the code bsaed upon review 

    Signed-off-by: BlackDex <black.dex@gmail.com>
    @BlackDex
    BlackDex committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    115ccb8 View commit details
    Browse the repository at this point in the history