Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't infer manage permission for groups #5190

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

stefan0xC
Copy link
Contributor

the web-vault v2024.6.2 currently cannot deal with manage permission so instead of relying on the org user type this should just default to false (until we implement this correctly).

should fix #5160

the web-vault v2024.6.2 currently cannot deal with manage permission so
instead of relying on the org user type this should just default to false
@BlackDex
Copy link
Collaborator

Is this only for groups? Or also collections? Because it works there if I'm correct. I have tested it with groups and collections so i find it strange this now needs to be reverted.

Ill have to check again a bit better. But if this fixes it.

@stefan0xC
Copy link
Contributor Author

This would be for giving groups edit or view access to collections. I don't think this currently needs to have the manage permission set to true but I might be wrong.

@BlackDex
Copy link
Collaborator

BlackDex commented Nov 12, 2024

I think the problem was with managers not able to handle stuff.
So maybe, since we have owners and admins can manage all, would make it to only need to be checked for managers if they need access?

@BlackDex
Copy link
Collaborator

Ok, did a quick check, looks like this should work. It should only be done for versions after this specific web-vault it looks like. Ill wait to see what you think @stefan0xC

@BlackDex
Copy link
Collaborator

Ok. Did some more checking. And i think this should be ok to fix the mentioned issue.
The original code is needed for 2024.10.5 as far as i have checked. But we are not there yet.

@dani-garcia dani-garcia merged commit ff33534 into dani-garcia:main Nov 13, 2024
5 checks passed
@stefan0xC stefan0xC deleted the fix-group-manage-permission branch November 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization groups permission on collections are not visible in 1.32.3
3 participants