Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing env vars for GitHub Scrape action #236

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

gczobel
Copy link
Contributor

@gczobel gczobel commented Feb 13, 2024

@daniel-hauser PTAL.
I found that the Scrape Action lack the env vars required to export to YNAB.
This PR fix that.

BTW.... the DEBUG is hardcoded to ""... this is intentional?

* fix: add missing env vars for GitHub Scrape action

* Update messages.ts
@daniel-hauser
Copy link
Owner

the DEBUG is hardcoded to ""... this is intentional?

Yes, as we don't want to accidently log in the public actions log

@daniel-hauser daniel-hauser merged commit 82ae1ae into daniel-hauser:main Feb 14, 2024
3 checks passed
gczobel added a commit to gczobel/moneyman that referenced this pull request Feb 21, 2024
* fix: add missing env vars for GitHub Scrape action (#2) (daniel-hauser#236)

* fix: add missing env vars for GitHub Scrape action

* Update messages.ts

* Bump husky from 9.0.10 to 9.0.11 (daniel-hauser#238)

Bumps [husky](https://github.com/typicode/husky) from 9.0.10 to 9.0.11.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v9.0.10...v9.0.11)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump dotenv from 16.4.1 to 16.4.4 (daniel-hauser#237)

Bumps [dotenv](https://github.com/motdotla/dotenv) from 16.4.1 to 16.4.4.
- [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md)
- [Commits](motdotla/dotenv@v16.4.1...v16.4.4)

---
updated-dependencies:
- dependency-name: dotenv
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: gczobel <754466+gczobel@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants