fix: build (#120)

fix: build and test for all compatible versions
daniel-sc · Nov 21, 2024 · acd3100 · acd3100
1 parent 9c2206a
commit acd3100
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 32 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -15,43 +15,30 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 18.x, 20.x]
-        angular-version: [13.2.6, 14.0.2, 15.0.3, 16.2.1, 17.0.0, 18.0.0-rc.3]
-        exclude:
-          - node-version: 18.x
-          - node-version: 20.x
-          - angular-version: 17.0.0
-          - angular-version: 18.0.0-rc.3
         include:
-          - angular-version: 13.2.6
-            devkit-version: 0.1302.6
-          - angular-version: 14.0.2
-            devkit-version: 0.1400.2
-          - angular-version: 15.0.3
-            devkit-version: 0.1500.3
-          - angular-version: 16.2.1
-            devkit-version: 0.1602.1
-          - angular-version: 16.2.1
-            devkit-version: 0.1602.1
-            node-version: 18.x
-          - angular-version: 17.0.0
-            devkit-version: 0.1700.0
-            node-version: 18.x
-          - angular-version: 17.0.0
-            devkit-version: 0.1700.0
-            node-version: 20.x
-          - angular-version: 18.0.0-rc.3
-            devkit-version: 0.1800.0-rc.3
-            node-version: 20.x
+          - {angular: {version: 13.2.6, devkit-version: 0.1302.6}, node: {version: 14.x, types-version: 14.14.31}}
+          - {angular: {version: 13.2.6, devkit-version: 0.1302.6}, node: {version: 16.x, types-version: 16.11.68}}
+          - {angular: {version: 14.0.2, devkit-version: 0.1400.2}, node: {version: 14.x, types-version: 14.14.31}}
+          - {angular: {version: 14.0.2, devkit-version: 0.1400.2}, node: {version: 16.x, types-version: 16.11.68}}
+          - {angular: {version: 15.0.3, devkit-version: 0.1500.3}, node: {version: 14.x, types-version: 14.14.31}}
+          - {angular: {version: 15.0.3, devkit-version: 0.1500.3}, node: {version: 16.x, types-version: 16.11.68}}
+          - {angular: {version: 15.0.3, devkit-version: 0.1500.3}, node: {version: 18.x, types-version: 18.15.3}}
+          - {angular: {version: 16.2.1, devkit-version: 0.1602.1}, node: {version: 16.x, types-version: 16.11.68}}
+          - {angular: {version: 16.2.1, devkit-version: 0.1602.1}, node: {version: 18.x, types-version: 18.15.3}}
+          - {angular: {version: 17.0.0, devkit-version: 0.1700.0}, node: {version: 18.x, types-version: 18.15.3}}
+          - {angular: {version: 17.0.0, devkit-version: 0.1700.0}, node: {version: 20.x, types-version: 20.17.6}}
+          - {angular: {version: 18.0.0, devkit-version: 0.1800.0}, node: {version: 18.x, types-version: 18.15.3}}
+          - {angular: {version: 18.0.0, devkit-version: 0.1800.0}, node: {version: 20.x, types-version: 20.17.6}}
+          - {angular: {version: 18.0.0, devkit-version: 0.1800.0}, node: {version: 22.x, types-version: 20.9.1}}
 
     steps:
     - uses: actions/checkout@v2
-    - name: Use Node.js ${{ matrix.node-version }}
+    - name: Use Node.js ${{ matrix.node.version }}
       uses: actions/setup-node@v1
       with:
-        node-version: ${{ matrix.node-version }}
+        version: ${{ matrix.node.version }}
     - run: rm package-lock.json # otherwise we cannot overwrite the peerDependencies version of @angular-devkit/build-angular below
-    - run: npm i --save-exact "@angular-devkit/architect@${{ matrix.devkit-version }}" "@angular-devkit/core@${{ matrix.angular-version }}" "@angular-devkit/schematics@${{ matrix.angular-version }}" "@schematics/angular@${{ matrix.angular-version }}" "@angular-devkit/build-angular@${{ matrix.angular-version }}" "@angular/core@${{ matrix.angular-version }}" "@angular/compiler-cli@${{ matrix.angular-version }}"
+    - run: npm i --save-exact "@types/node@${{ matrix.node.types-version }}" "@angular-devkit/architect@${{ matrix.angular.devkit-version }}" "@angular-devkit/core@${{ matrix.angular.version }}" "@angular-devkit/schematics@${{ matrix.angular.version }}" "@schematics/angular@${{ matrix.angular.version }}" "@angular-devkit/build-angular@${{ matrix.angular.version }}" "@angular/core@${{ matrix.angular.version }}" "@angular/compiler-cli@${{ matrix.angular.version }}"
     - run: npm i
     - run: npm ls || true
     - run: npm run build
@@ -60,7 +47,7 @@ jobs:
       uses: coverallsapp/github-action@v1.1.2
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}
-        flag-name: run-${{ matrix.node-version }}
+        flag-name: run-${{ matrix.node.version }}
         parallel: true
 
   finish:

diff --git a/tsconfig.json b/tsconfig.json
@@ -5,7 +5,7 @@
 
     /* Basic Options */
     // "incremental": true,                         /* Enable incremental compilation */
-    "target": "ES2015",                                /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */
+    "target": "ES2019",                                /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */
     "module": "commonjs",                           /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', 'es2020', or 'ESNext'. */
     // "lib": [],                                   /* Specify library files to be included in the compilation. */
     // "allowJs": true,                             /* Allow javascript files to be compiled. */