Space trimming

[yehorlitsov]

Looks like extract-i18n-merge command trims spaces, but extract-i18n don't. I have cases when i don't need to trim them.

<span
  class="link-ghost"
  i18n="Phone Verification"
> Change</span>

I have a space before Change. But as a result i have:

<trans-unit id="ba3ab8408e0985aaa20a3c83f77a8bc336a96ae4" datatype="html">
  <source>Change</source>
  <context-group purpose="location">
    ...
  </context-group>
  <note priority="1" from="description">Phone Verification</note>
</trans-unit>

May be there is any extra config except collapseWhitespace?
"ng-extract-i18n-merge": "^1.4.0",

[daniel-sc]

Hi @yehorlitsov
Thanks for your feedback. This option is not yet available. Before adding it I'd like to understand why it is needed. In my experience these white spaces get trimmed in the ng build - so it makes no difference for the final output. But please let me know why you'd rather not have it trimmed!
Best
Daniel

[yehorlitsov]

Hi!
Yes, sorry, might be i provided incomplete information and forgot to greeting :)
npm run extract-i18n build everything without trimming, like i mentioned in first message, in such cases like this

<div>
  <ng-container>Some string </ng-container>
  <span>{{someValue}}</span>
  <span> some final.</span>
</div>

the result will be Some string VALUE some final.
But using nom run extract-i18n-merge the result after build will be Some stringVALUEsome final.
It's an issue for me, so i have to do something like this in each case:

<div>
  <ng-container>Some string</ng-container>
  <span>&nbsp;</span>
  <span>{{someValue}}</span>
  <span>&nbsp;</span>
  <span> some final.</span>
</div>

Before i used npm run extract-i18n and @ngx-i18nsupport/tooling with its xlf-merge, but after update to Angular 13 had an issue with lib. So that's why i switched to yours, and everything works great except this one small thing.
Thank you!
Best
Yehor

[daniel-sc]

@yehorlitsov you are right (angular compiler removes whitespaces between nodes, but not within..)

[daniel-sc]

@yehorlitsov would you mind checking out the pre-release 2.0.0-0 and report back if it works as intended from your side?

[yehorlitsov]

@daniel-sc thank you, this pre-release 2.0.0-0 solved the problem for me. Sorry for long reply

[Hafnernuss]

If this is completly resolved, maybe consider removing

Leading/trailing whitespaces are normalized (i.e. collapsed to one space) but not completely trimmed (#28).
from the docs? 🤔