Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Studio Flow Execution + Step #125

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Add Studio Flow Execution + Step #125

merged 1 commit into from
Nov 28, 2019

Conversation

jc00ke
Copy link
Contributor

@jc00ke jc00ke commented Oct 15, 2019

No description provided.

@jc00ke
Copy link
Contributor Author

jc00ke commented Oct 15, 2019

I'd be happy to write some tests, but it doesn't look like there are any for the specific endpoints. Let me know if you would like me to add some.

I did test it against our actual flow executions and it worked 😗 👌

One departure is that you have to know both the flow_sid and the execution_sid to get the steps. I figured passing it in the options would be the most compatible way to handle those values.

@jc00ke
Copy link
Contributor Author

jc00ke commented Nov 19, 2019

Hi there @danielberkompas! Is there anything else I can provide on this PR? Thanks!

@danielberkompas
Copy link
Owner

This looks good, thanks! ⭐ ⭐ ⭐

@danielberkompas danielberkompas merged commit 67b75f3 into danielberkompas:master Nov 28, 2019
@jc00ke jc00ke deleted the flow-executions branch March 11, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants