Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialyzer errors #150

Merged
merged 2 commits into from
Jun 5, 2021

Conversation

drgmr
Copy link
Contributor

@drgmr drgmr commented Mar 18, 2021

I'm now using this lib as a dependency on a private project and our dialyzer checks complained that a call to ExTwilio.JWT.AccessToken.to_jwt!/1 would make the enclosing function have no local return. After some digging I've found the culprit - the success typing for Joken.generate_and_sign!/3 requires that the second params is a map instead of nil.

That's one of the changes - I've also taken the opportunity to fix the remaining dialyzer errors on the project and added a new step to the Semaphore CI checks so we can ensure no more issues arise.

@danielberkompas danielberkompas merged commit ee0206b into danielberkompas:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants