Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm now using this lib as a dependency on a private project and our dialyzer checks complained that a call to
ExTwilio.JWT.AccessToken.to_jwt!/1
would make the enclosing function have no local return. After some digging I've found the culprit - the success typing forJoken.generate_and_sign!/3
requires that the second params is a map instead ofnil
.That's one of the changes - I've also taken the opportunity to fix the remaining dialyzer errors on the project and added a new step to the Semaphore CI checks so we can ensure no more issues arise.