Fix package.json scripts to be cross-platform #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm it looks like doing i.e. |
danielcaldas
requested changes
Aug 13, 2020
There was a problem hiding this comment.
Hey @TranquilMarmot thanks for the PR, you might need to add cross-env to the dev dependencies in order for the CI to install the dependency. It's probably working in your machine due to a global version of cross-env that you might have installed. Just npm install cross-env --save-dev should suffice. Cheers!
|
@danielcaldas Line 51 in b25dddf I wonder if cypress just isn't picking up the env var for some reason 🤔 |
|
Oh, I think you might need to wrap the var with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying
node_modules/binwas causing issues with these on Windows.Also, the cypress tests were using
exportinstead ofcross-envwhich was also breaking on Windows.