Update manifest.json to prevent conflicts with HA (fix for 2024.1) #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the package pinning into the suggested
>=format, so future updates to core package will not break this component - implementing the posts I shared in #301 (comment)Multiscrape should list the lowest needed version it is compatible with, and let core figure out which package to pick. There could be an upper bound as well, if a newer package is incompatible (i.e.:
lxmlis pinned to below 5.0.0 in HA core right now, as another integration breaks with that version). So if you need a newer version because of a fix, this should be updated. If it isn't needed, you can leave it as is and core will figure out what to do.Tested locally, works fine again on HA 2024.1. Someone should test for 2023.12.
Fixes #301