Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use 'IntoFuture' trait to await futures directly without calling 'send' #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danieleades
Copy link
Owner

this works now, but shouldn't be merged until the nightly features used in it are stabilised

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 46.21%. Comparing base (3b5255a) to head (46c4283).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/endpoints/transactions/list.rs 0.00% 5 Missing ⚠️
src/endpoints/feed_items.rs 0.00% 3 Missing ⚠️
src/endpoints/transactions/get.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   46.32%   46.21%   -0.11%     
==========================================
  Files          19       19              
  Lines         870      872       +2     
==========================================
  Hits          403      403              
- Misses        467      469       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danieleades danieleades closed this Jun 1, 2022
@danieleades danieleades reopened this Jun 1, 2022
@danieleades danieleades changed the title use 'IntoFutre' trait use 'IntoFuture' trait Dec 11, 2022
@danieleades danieleades force-pushed the into-future branch 2 times, most recently from bcb04ab to 531cf76 Compare November 25, 2023 10:12
@danieleades danieleades force-pushed the into-future branch 3 times, most recently from 046cee9 to af0ba56 Compare February 3, 2024 11:09
@danieleades
Copy link
Owner Author

blocked on rust-lang/rust#63063

@danieleades danieleades changed the title use 'IntoFuture' trait feat!: use 'IntoFuture' trait to await futures directly without calling 'send' Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant